Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling Bus::begin() sets Bus::sendTriesMax to default value NACK_RETRY_DEFAULT which is 3. #66

Open
Darthyson opened this issue Mar 28, 2023 · 0 comments
Open

calling Bus::begin() sets Bus::sendTriesMax to default value NACK_RETRY_DEFAULT which is 3. #66

Darthyson opened this issue Mar 28, 2023 · 0 comments
Labels
enhancement

Comments

@Darthyson
Copy link
Member

this also affects Bus::sendBusyTriesMax
Bus::maxSendTries(..) only works being called after Bus::begin()
I think it would be better to set the default values in ctor.
Also i think there is a naming confusion, as Bus::maxSendTries(..) actually sets the retries and not the total sending tries.
dallmair added a commit that referenced this issue Jan 30, 2024
@dallmair
Rename (max)send(Busy)Tries and fix initialization
3d9d5b3 
As the fields contain the number of retries, they should be named
accordingly to prevent confusion. Furthermore, initialization to the
default values should happen in the constructor instead of the `begin()`
method.

Closes #66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Darthyson