Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phase amplitude calculator #274

Open
sebmagia opened this issue Feb 22, 2024 · 1 comment
Open

Add phase amplitude calculator #274

sebmagia opened this issue Feb 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sebmagia
Copy link

Hello,

Can a feature be added that computes the phase amplitude for the pickers? PhaseNet's original implementation does it; I don't know about the other pickers.

Kind regards,

Sebastian

@yetinam yetinam added the enhancement New feature or request label Feb 23, 2024
@yetinam
Copy link
Member

yetinam commented Feb 23, 2024

Hi @sebmagia ,

thanks for the suggestion. As you've spotted, this is currently not implemented in SeisBench. The reason for omitting this from the models themselves it that it adds a requirement for instrument response information. In addition, amplitude extraction is sensitive to parameter settings, such as the band to select from or the components. However, it could be implemented as an additional class or function to post-process the picks.

Asides the response removal and appropriate filtering, extracting amplitudes is rather straightforward once you have the picks. It should be rather quick to code up for users.

Nonetheless, I'll leave this issue open as a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants