Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Split into static checks and tests #982

Open
Lorak-mmk opened this issue Apr 18, 2024 · 0 comments
Open

CI: Split into static checks and tests #982

Lorak-mmk opened this issue Apr 18, 2024 · 0 comments
Labels
symptom/ci stability Related to continuous integration
Milestone

Comments

@Lorak-mmk
Copy link
Collaborator

Lorak-mmk commented Apr 18, 2024

Currently our main CI has 1 main job which performs static checks with cargo fmt / check / clippy and tests
If we split tests into separate job from static checks:

  • CI code would be clearer and more readable imo
  • Formatting / linting problems would not prevent tests from being run - this is sometimes frustrating when you push something, return to it later to see results of the tests and see that tests didn't run because of some formatting problem.
  • Test more feature combinations without big penalty in running time: tests would probably still take more time
  • Possibly speed up CI: tests don't have to wait for static checks
@wprzytula wprzytula added the symptom/ci stability Related to continuous integration label Apr 19, 2024
@wprzytula wprzytula added this to the 1.1.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
symptom/ci stability Related to continuous integration
Projects
None yet
Development

No branches or pull requests

2 participants