Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultPolicy test: change test nodes to be multi shard #973

Open
Lorak-mmk opened this issue Mar 26, 2024 · 0 comments
Open

DefaultPolicy test: change test nodes to be multi shard #973

Lorak-mmk opened this issue Mar 26, 2024 · 0 comments
Labels
load-balancing
Milestone
1.1.0

Comments

@Lorak-mmk
Copy link
Collaborator

Currently tests for DefaultPolicy use nodes with 1 shard. This means we have no way to test if the policy returns correct shards, not only correct nodes.
We should add a constructor for Node (accessible only by tests) to allow us to specify shard amount and modify the tests to verify returned shards too.
@wprzytula wprzytula changed the title DefaultPolict test: change test nodes to be multi shard DefaultPolicy test: change test nodes to be multi shard Apr 11, 2024
@wprzytula wprzytula added this to the 1.1.0 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
load-balancing
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@Lorak-mmk @wprzytula