Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not working with Django 3 #84

Open
TAnas0 opened this issue Dec 17, 2021 · 1 comment
Open

Tests not working with Django 3 #84

TAnas0 opened this issue Dec 17, 2021 · 1 comment

Comments

@TAnas0
Copy link

TAnas0 commented Dec 17, 2021

I am using:

  • Django 3.2.10
  • Python 3.8
  • django-softdelete 0.9.2 (latest in PyPi, published 15 Oct 2020)

Running the tests, as instructed in the Readme django-admin.py test softdelete --settings="softdelete.settings" results in the following error:

...
from django.shortcuts import render_to_response, get_object_or_404, redirect
ImportError: cannot import name 'render_to_response' from 'django.shortcuts'

It's a compatibility issue with Django 3 which was resolved in this PR #77
When I install the latest commit using pip the tests run fine.
So I guess this is more of an issue about publishing the latest changes to PyPi. Maybe it's time for a major version 🙂

Somewhat related issues:

@TAnas0
Copy link
Author

TAnas0 commented Dec 17, 2021

@scoursen And BTW, I can help you setup a CI pipeline that deploys to PyPi on Github releases (or something similar) if need be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant