Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Sliding is applied when using median as pivot in cKDTree, should only be used for midpoint #20605

Open
sturlamolden opened this issue Apr 29, 2024 · 0 comments · May be fixed by #20606
Open

BUG: Sliding is applied when using median as pivot in cKDTree, should only be used for midpoint #20605

sturlamolden opened this issue Apr 29, 2024 · 0 comments · May be fixed by #20606
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.spatial
Milestone
1.14.0

Comments

@sturlamolden
Copy link
Contributor

sturlamolden commented Apr 29, 2024 •
edited

As the title says…

The bug relates to how the kd-tree is constructed and internally balanced and does not produce a logic error.

However, sliding midpoint is sliding midpoint. Median is median. Sliding median is not a thing.

This bug has been fixed before, commit a69718a, but has reappeared. Regression due to commit d13a48c.

@peterbell10
@github-actions github-actions bot added the defect A clear bug or issue that prevents SciPy from being installed or used as expected label Apr 29, 2024
@sturlamolden sturlamolden linked a pull request Apr 29, 2024 that will close this issue
Open
@tylerjereddy tylerjereddy added this to the 1.14.0 milestone Apr 29, 2024
sturlamolden added a commit to sturlamolden/scipy that referenced this issue May 8, 2024
@sturlamolden
add test for scipygh-20605
ea4f65e
sturlamolden added a commit to sturlamolden/scipy that referenced this issue May 8, 2024
@sturlamolden
turn test for scipygh-20605 back on
45dc44d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.spatial
Projects
None yet
Milestone
1.14.0
Development

Successfully merging a pull request may close this issue.

BUG: spatial.cKDTree: do not slide the median sturlamolden/scipy
3 participants
@sturlamolden @tylerjereddy @lucascolley