ENH: special: add log_wright_bessel
#20646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wb_large_a more numerically stabel - wb_small_a factored out C and X coefficients - comments improved
github-actions
bot
added
scipy.special
C/C++
lucascolley
changed the title
log_wright_bessel
lorentzenchr
force-pushed
the
log_wright_bessel
branch
from
72c9cf3
to
4523998
Compare
|
Thanks @lorentzenchr! This is excellent work. I'll give this a close sometime in the next week. |
steppi
approved these changes
May 7, 2024
There was a problem hiding this comment.
This looks great @lorentzenchr! Nice work getting all of the infrastructure stuff right before we've even documented it.
Comment on lines
+163
to
167
| A[4] = X[1] * (C[0] + C[1] * b + C[2] * B[2] + C[3] * B[3] + C[4] * B[4]); | ||
| A[3] = X[2] / 2. * (C[1] + C[2] * b + C[3] * B[2] + C[4] * B[3]); | ||
| A[2] = X[3] / 6. * (C[2] + C[3] * b + C[4] * B[2]); | ||
| A[1] = X[4] / 24. * (C[3] + C[4] * b); | ||
| A[0] = X[5] / 120. * C[4]; |
There was a problem hiding this comment.
It does look nice lined up like this, but we've been using clang-format to format the code in this folder: https://github.com/scipy/scipy/blob/main/scipy/special/special/.clang-format. I think it's fine to merge it like this, but just giving you a heads up that the formatting here is likely to be automatically changed back in the future.
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-20598
What does this implement/fix?
This PR adds the special function
log_wright_bessel, i.e. the logarithm of Wright's Bessel function.Additional information
Simply put, this might be (one of) the hardest to evaluate special function in scipy.special. Taking the logarithm makes the possible domain of the 3 parameters even larger.