Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many tests are failing due to self-closing tags in HTML #260

Open
Aloisius opened this issue Jan 20, 2024 · 1 comment
Open

Many tests are failing due to self-closing tags in HTML #260

Aloisius opened this issue Jan 20, 2024 · 1 comment

Comments

@Aloisius
Copy link
Contributor

Aloisius commented Jan 20, 2024

It looks like #250 started self-closing void tags like <img> tags which broke a whole bunch of tests.

Self-closing tags (<tag />) do not exist in HTML. While it's explicitly ignored in HTML5, it's technically invalid in HTML4 though in practice parsers ignore it. Either the change should be reverted or all the tests should be fixed.

Perhaps a GitHub Action should be setup to test builds during pull requests/push?

@Aloisius Aloisius changed the title Many tests are failing in 2.7.0 Many tests are failing due to self-closing tags in HTML Jan 20, 2024
@scinfu
Copy link
Owner

scinfu commented Feb 12, 2024

At this moment i do not have time to make changes until 7/2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants