New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set LDFLAGS and CPPFLAGS for keg-only libomp in CI config #7407
base: main
Are you sure you want to change the base?
Conversation
This job started to fail with ../meson.build:1:0: ERROR: Compiler /usr/bin/clang cannot compile programs. The output while running "brew install libomp" suggests that the mentioned flags need to be set accordingly. So check whether this addresses the issue.
Great news the compilation works now. However, the tests fail...
|
@stefanv do you maybe want to take a look at the failing |
Note that macos-latest switched from 12.7.4 to 14.4.1. |
The moments failure is innocuous:
|
The ellipse failure: the ellipse parameters a and b are correctly estimated (good!). The angle is given as 135 instead of 45. I don't think a pi/2 correction is needed in this case, yet it was added.
a is definitely larger than c in this case, but what does that comparison do? The code above is from #2482 I think we should carefully look at https://mathworld.wolfram.com/Ellipse.html#eqn23 too. Question is: why does this pop up now, and only on newer macos / clang compiler? They must have a math library with different trigonometric branching. The parameter stabilization, just below the above, seems fine:
|
Temporary fix until scikit-image#7407 is resolved
As a temporary workaround, we can merge #7408. This PR will need to be rebased and revert that commit. Also note that macos-latest is now macos-14-arm64 (it used to be macos-12): |
Temporary fix until #7407 is resolved
Description
Closes #7406. The output while running "brew install libomp" suggests that the mentioned flags need to be set accordingly. So check whether this addresses the issue.
Checklist
./doc/examples
for new featuresRelease note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.