Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with release notes link on front page #1

Open
grlee77 opened this issue Feb 17, 2022 · 8 comments
Open

problem with release notes link on front page #1

grlee77 opened this issue Feb 17, 2022 · 8 comments

Comments

@grlee77
Copy link

grlee77 commented Feb 17, 2022

The "release notes" link as in the screenshot below points to the "master" branch rather than the stable v0.19.x branch. At minimum, the "master" in the link is outdated and should be updated to "main" (although automatic redirect is currently working okay).

I noticed this because despite releasing 0.19.2 today, the link there still showed only v0.19.0 release notes. I should have just made the release note PRs to main and then backported them to v0.19.x so this could not occur. However, shouldn't the "stable" release notes link point to the file in the v0.19.x branch instead?

release_notes_link

@jni
Copy link
Member

jni commented Feb 18, 2022

Yes I think they should.

@jni
Copy link
Member

jni commented Feb 18, 2022

@stefanv
Copy link
Member

stefanv commented Feb 18, 2022

I get the 0.19.2 release notes when I click on the frontpage link.

@grlee77
Copy link
Author

grlee77 commented Feb 18, 2022

I get the 0.19.2 release notes when I click on the frontpage link.

That's because @jni merged scikit-image/scikit-image#6253 so that those notes are also on main

@stefanv
Copy link
Member

stefanv commented Feb 18, 2022

Perfect, thanks!

@stefanv stefanv closed this as completed Feb 18, 2022
@jni
Copy link
Member

jni commented Feb 19, 2022

@stefanv That doesn't address the bigger problem — that stable should point to stable rather than main?

@jni jni reopened this Feb 19, 2022
@stefanv
Copy link
Member

stefanv commented Feb 19, 2022

Seems like a good check to ensure that we remember committing those notes in the right place, though?

@jni
Copy link
Member

jni commented Apr 6, 2022

I feel like a broken public website is not the best indicator for this sort of thing. Something like a GitHub Action check would be better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants