Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: do linkcheck on SPECS docs #251

Open
bsipocz opened this issue Aug 1, 2023 · 4 comments
Open

CI: do linkcheck on SPECS docs #251

bsipocz opened this issue Aug 1, 2023 · 4 comments

Comments

@bsipocz
Copy link
Member

bsipocz commented Aug 1, 2023

Some of the specs are full of links to third party pages of tools and other resources. We need to make sure these links don't rot over time.

@jarrodmillman
Copy link
Member

jarrodmillman commented Aug 1, 2023

We check links with netlify:

package = "netlify-plugin-checklinks"

@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2023

ah, OK. Also from cron? E.g. I don't expect a link to not work at the time of adding it freshly in the PR.

@stefanv
Copy link
Member

stefanv commented Aug 1, 2023

No cron checks right now. Link checks are quite expensive, but we could do it once a week or so and file an issue. But I haven't set that up before, so hoping someone else is interested...

@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2023

Oh, sure, I'm not suggesting more frequent checks than weekly/fortnightly.
I do have projects that run linkchecks, but all of those are either rely on jupyter-book or sphinx linkcheck functionality, but I'm sure someone have already found a linkcheck action that works reasonably well so we can just pull the config from an existing project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants