Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC10 on release documentation #242

Open
pllim opened this issue Jul 14, 2023 · 7 comments · May be fixed by #321
Open

SPEC10 on release documentation #242

pllim opened this issue Jul 14, 2023 · 7 comments · May be fixed by #321

Comments

@pllim
Copy link
Contributor

pllim commented Jul 14, 2023

As discussed briefly during Scipy 2023. cc @bsipocz @lagru

after all we were asked for opinionated ideas

becareful what you wish for

Might be useful. Even if just to collect/build community consensus what should be present in release notes and how best to achieve that!

@pllim
Copy link
Contributor Author

pllim commented Jul 16, 2023

I think we agreed on the following:

  • High level recommendations on best practices. Don't dwell into details that can get outdated fast.
  • Change log is meant for users. Therefore, it should not include things like test changes, doc changes, refactoring without any functionality changes.
  • There are different ways to do change log and it depends on how active a project is and the number of contributors.

Ways to do change log:

  • Use GitHub built-in release notes generation at release time. It is available during GitHub Release step. Very easy to use but you cannot see the change log until release time and the auto generated text needs cleaning. It also only captures PRs, not direct pushes that are not recommended anyway.
  • lagru's Action to build change log from commits. bsipocz and lagru can fill out details here.
  • A single CHANGES.rst file that contributors edit by hand. Change log is ready to go on main whenever. But high risk to cause PR merge conflict if lots of activity. Entries need to be moved manually if PR misses milestone. Need extra script for consistency check. Milestone check needs to be refactored to work with auto milestone that is applied only after merge.
  • towncrier fragments. Do not cause merge conflict. Can be rendered into change log on RTD using sphinx-changelog in OpenAstronomy but the rendered version is not fed back to main. Final rendered change log is done at release time on release branch, which will also delete rendered fragments. This rendering then needs to be forwardported to main. Too heavyweight for simple projects. Sometimes new towncrier release breaks our stuff.

@stefanv
Copy link
Member

stefanv commented Jul 16, 2023

Thanks for taking on this topic. It'd be interesting to see what coalesces out of all the opinions.

Re principle 2, I'd say leave decisions of what to include to the project. There are some essentials (API changes etc.) but then doc updates etc. will depend on how fine grained the project wishes to be.

@stefanv
Copy link
Member

stefanv commented Sep 18, 2023

Saw this in ics-py release notes: https://keepachangelog.com/en/1.0.0/

@pllim
Copy link
Contributor Author

pllim commented Sep 18, 2023

Does this mean our work is done? Hard for me to tell who wrote that though.

@lagru
Copy link
Member

lagru commented Oct 3, 2023

Re who wrote it, you can find the repo and its author here https://github.com/olivierlacan/keep-a-changelog.

@InessaPawson
Copy link
Contributor

IMHO it still would be helpful to have a dedicated SPEC to bring visibility to this topic in our ecosystem.

@InessaPawson
Copy link
Contributor

InessaPawson commented Jun 3, 2024

@pllim @stefanv @lagru I'll be working on a draft for this SPEC during 2024 Scientific Python Summit. This will be SPEC10.

@InessaPawson InessaPawson changed the title SPEC on change log SPEC 0010 on changelog Jun 3, 2024
@InessaPawson InessaPawson changed the title SPEC 0010 on changelog SPEC10 on release documentation Jun 5, 2024
@InessaPawson InessaPawson linked a pull request Jun 5, 2024 that will close this issue
@pllim pllim linked a pull request Jun 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants