Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign navbar #566

Open
2 tasks
jarrodmillman opened this issue Mar 26, 2024 · 4 comments
Open
2 tasks

Redesign navbar #566

jarrodmillman opened this issue Mar 26, 2024 · 4 comments

Comments

@jarrodmillman
Copy link
Member

jarrodmillman commented Mar 26, 2024

Investigate PST navbar styling. We won't do the exact same, but there are a couple of things to look into.

  • dropdown menu items
  • how to use header, nav, div, ul, li, button, etc...
  • should hamburger menu use spans or svgs (or should it say menu)
  • should navbar be full device width
  • what are best breakpoints?
@smeragoel
Copy link

I found some issues with the navbar (some of them might be covered by these changes suggested above):

  1. The logo on the navbar should be left aligned with the rest of the content on the page.
image
  1. The dropdown has some empty/placeholder menu items.
    image

  2. The theme is using the system theme for choosing between light / dark theme, but we should have a theme switcher on the navbar as well.

  3. The navbar content seems to be "floating" right now, because the navbar colour is the same as the page background colour, and there is no stroke on the bottom of the navbar to diifferentiate it from the rest of the page. I can work on the design if you agree with my suggestion!

@stefanv
Copy link
Member

stefanv commented May 3, 2024

Navbar is still styled to fade in, e.g., when switching light to dark theme. Search for transition: to locate these.

@Bashamega
Copy link

Hello :)
I would like to work on this issue.
All I need is for you to assign me the issue and tell me which file is the nav bar in.

@jarrodmillman jarrodmillman changed the title Redo navbar Redesign navbar May 6, 2024
@jarrodmillman
Copy link
Member Author

@Bashamega Thanks for volunteering. This is probably not a good place to start as we still haven't figured out what the new design will be. I see that pybamm.org is using the theme. You should take a look at #602. There will be a few breaking changes in the next release that you should pay attention to, which I will gather in #602.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants