Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper route for custom colours #263

Open
AA-Turner opened this issue Sep 17, 2023 · 2 comments
Open

Proper route for custom colours #263

AA-Turner opened this issue Sep 17, 2023 · 2 comments
Assignees

Comments

@AA-Turner
Copy link

I'm investigating adopting this theme for Econ-ARK, which has a palette of brand colours. I'm aware we can use custom stylesheets at assets/css/*.css, but I wondered if this would be the proper route to override theme colours, or if there's a better way?

Specifics would perhaps be the CSS variable names for the colours (or: integration into config.yaml), which to override, etc -- or a statement that users of this theme should leave the colours alone as it hurts consistency.

Thanks,
Adam

@alphapapa alphapapa self-assigned this Sep 25, 2023
@alphapapa
Copy link
Contributor

Hi fellow Adam,

At the moment we're doing some refactoring, adding dark mode, and planning to do some integration or unification with the pydata-sphinx-theme. So you might want to wait until that's done before doing too much customization.

Anyway, my rough intention (to the extent that my ideas are approved) is for colors to be defined "purposefully" (i.e. sets of color variables are named according to their purpose in the theme), which should make it easy to develop customizations (such as light/dark mode, etc) by applying different color values to those variables.

If you're interested, you could keep an eye on #229 and #225, and feel free to offer feedback on them.

Thanks.

@stefanv
Copy link
Member

stefanv commented Oct 24, 2023

Meanwhile, overriding the variables is the correct way to set theme colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants