Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default module should be called index (not main) #4856

Open
gzm0 opened this issue Apr 22, 2023 · 3 comments
Open

The default module should be called index (not main) #4856

gzm0 opened this issue Apr 22, 2023 · 3 comments
Labels
enhancement Feature request (that does not concern language semantics, see "language")

Comments

@gzm0
Copy link
Contributor

gzm0 commented Apr 22, 2023

I realized this when looking at gemini-hlsw/lucuma-core#708 (comment)

index.js / index.ts is special in the entire JS ecosystem as the "default" module (similar to __init__.py in python).

It is likely not worth it to change this now, but opening this anyways so we can have the discussion.

@sjrd
Copy link
Member

sjrd commented Apr 22, 2023

More annoying than worth it or not, it's likely a breaking change. I don't see how we would change that.

@gzm0
Copy link
Contributor Author

gzm0 commented Apr 22, 2023

Yes, it is for sure a breaking change in practice. Maybe it goes on the Scala.js 2.x list? :P

@sjrd
Copy link
Member

sjrd commented Apr 22, 2023

It's probably 2.x territory, yes :p

@sjrd sjrd added the enhancement Feature request (that does not concern language semantics, see "language") label May 17, 2023
@sjrd sjrd added this to the v2.x (not planned) milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request (that does not concern language semantics, see "language")
Projects
None yet
Development

No branches or pull requests

2 participants