Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds deprecation warnings for the Module and the Class method Solrizer.solr_name #51

Conversation

jrgriffiniii
Copy link
Contributor

Resolves #45

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 97.581% when pulling ff71ab7 on jrgriffiniii:issues-45-jrgriffiniii-deprecation into 6a53933 on samvera:master.

@jcoyne
Copy link
Contributor

jcoyne commented Sep 21, 2018

This doesn't make sense to me. This is the primary feature of solrizer. Deprecating it's primary function seems wrong. Can you just stop using it if you don't need it?

@tpendragon
Copy link
Contributor

I think I'm with @jcoyne here.

@jrgriffiniii
Copy link
Contributor Author

It's deprecated (as in we discourage its use) in modern versions of Hyrax/HydraHead, but I still use it with my very old Hydra-Head (7.x) applications. I'd prefer not to see deprecation warnings there, because it's perfectly reasonable to use it in an old Hydra-head.

This is seems to be the consensus here.

Component Maintenance automation moved this from Review to Done May 9, 2019
@tpendragon tpendragon removed this from Done in Component Maintenance Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue deprecation warnings
4 participants