Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SelectsCollections into service class #903

Open
atz opened this issue Aug 16, 2016 · 0 comments
Open

Refactor SelectsCollections into service class #903

atz opened this issue Aug 16, 2016 · 0 comments
Assignees

Comments

@atz
Copy link
Contributor

atz commented Aug 16, 2016

https://github.com/projecthydra/curation_concerns/blob/99b38015bca4bb621c476325978293b755b7f131/app/controllers/concerns/curation_concerns/selects_collections.rb#L33-L37

The requirement of blacklight configuration means this is unavailable to non-controller code, but the functionality should certainly be available throughout the codebase, including to async jobs, reports, anywhere a User object exists, etc.

Refactor to permit something like:

CollectionService.collections_for_user_with_edit(blacklight_config, user)
@atz atz self-assigned this Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant