Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore a better approach to styling with the Material UI #30

Open
jrgriffiniii opened this issue Feb 19, 2020 · 1 comment
Open

Explore a better approach to styling with the Material UI #30

jrgriffiniii opened this issue Feb 19, 2020 · 1 comment
Assignees
@adamjarling
Labels
spike
Projects
BrowseEverything Redux/React
Milestone
1.0.0.rc1

Comments

@jrgriffiniii
Copy link
Collaborator

The useTheme Hook seems to provide much of the behavior I was injecting the using ad-hoc Objects as props for passing CSS styling rules: https://material-ui.com/styles/advanced/#accessing-the-theme-in-a-component

Theming should probably be used for the overall styling of this, as there is a fairly detailed guide describing some best practices for this approach: https://material-ui.com/customization/theming/
@jrgriffiniii jrgriffiniii added the enhancement New feature or request label Feb 19, 2020
@jrgriffiniii jrgriffiniii added this to the 1.0.0.rc1 milestone Feb 19, 2020
@jrgriffiniii jrgriffiniii added this to Inbox in BrowseEverything Redux/React via automation Feb 19, 2020
@adamjarling adamjarling self-assigned this Feb 21, 2020
@adamjarling
Copy link
Contributor

This fairly easily goes with #32

@jrgriffiniii jrgriffiniii added spike and removed enhancement New feature or request labels Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjarling adamjarling

Labels
spike
Projects
BrowseEverything Redux/React
  
Inbox
Milestone
1.0.0.rc1
Development

No branches or pull requests
2 participants
@jrgriffiniii @adamjarling