Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How is openid_connect_signing_key handled? #2912

Open
ebarped opened this issue Mar 6, 2024 · 1 comment
Open

How is openid_connect_signing_key handled? #2912

ebarped opened this issue Mar 6, 2024 · 1 comment

Comments

@ebarped
Copy link

ebarped commented Mar 6, 2024 •
edited

Same as #2420, we should add support for openid_connect_signing_key inside secrets file. If we dont have support for specifying it as an env var previous to the runtime, each restart will generate a new key, and errors in 2FA, settings, webhooks, MR... etc will happen.

Also, the users would not be able to restore from a backup, since this key will change.
ebarped added a commit to ebarped/docker-gitlab that referenced this issue Mar 6, 2024
@ebarped
sameersbn#2912 Handle openid_connect_signing_key variable to enable b…
e08c7b5 
…ackup/restore & restarts without errors
ebarped added a commit to ebarped/docker-gitlab that referenced this issue Mar 7, 2024
@ebarped
'sameersbn#2912 Handle openid_connect_signing_key variable to enable …
a73f8d5 
…backup/restore & restarts without errors'
@ebarped ebarped mentioned this issue Mar 7, 2024
Open
ebarped added a commit to ebarped/docker-gitlab that referenced this issue Mar 7, 2024
@ebarped
'sameersbn#2912 Handle openid_connect_signing_key variable to enable …
d89ea79 
…backup/restore & restarts without errors'
@ebarped
Copy link
Author

ebarped commented Mar 7, 2024

Resolved in #2913

ebarped added a commit to ebarped/docker-gitlab that referenced this issue Mar 7, 2024
@ebarped
'sameersbn#2912 Handle openid_connect_signing_key variable to enable …
0d6edd9 
…backup/restore & restarts without errors'
ebarped added a commit to ebarped/docker-gitlab that referenced this issue Mar 7, 2024
@ebarped
'sameersbn#2912 Handle openid_connect_signing_key variable to enable …
de0c72b 
…backup/restore & restarts without errors'
ebarped added a commit to ebarped/docker-gitlab that referenced this issue Mar 7, 2024
@ebarped
'sameersbn#2912 Handle openid_connect_signing_key variable to enable …
e8b9e7d 
…backup/restore & restarts without errors'
ebarped added a commit to ebarped/docker-gitlab that referenced this issue Mar 7, 2024
@ebarped
'sameersbn#2912 Handle openid_connect_signing_key variable to enable …
2ce9567 
…backup/restore & restarts without errors'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebarped