Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Build failes due to Bazel 7.0.0 breaking change #291

Open
3 tasks done
rhaps0dy opened this issue Jan 4, 2024 · 0 comments
Open
3 tasks done

[BUG] Build failes due to Bazel 7.0.0 breaking change #291

rhaps0dy opened this issue Jan 4, 2024 · 0 comments
Assignees

Comments

@rhaps0dy
Copy link

rhaps0dy commented Jan 4, 2024

Describe the bug

When building in the default Docker env, the following error comes up

ERROR: /app/envpool/atari/BUILD:20:8: output 'envpool/atari/roms' of //envpool/atari:gen_atari_roms is a directory; dependency checking of directories is unsound
ERROR: /app/envpool/atari/BUILD:20:8: Executing genrule //envpool/atari:gen_atari_roms failed: not all outputs were created or valid

To Reproduce

  1. Run make docker-dev
  2. Inside the container run make bazel-debug

Expected behavior

The code builds

System info

I reproduced this bug:

  • under Orbstack docker on Mac. which is a x86 VM
  • in a x86_64 Ubuntu machine.

Reason and Possible fixes

I was able to work around this by setting export USE_BAZEL_VERSION=6.4.0. Then Bazelisk downloads and runs the appropriate Bazel version. I suggest adding that to the documentation.

Bazel 7.0.0 disables version checking for directories and symlinks, because it's unsound. (I gleaned this from this GitHub issue) Envpool has some genrules that output directories.

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have read the documentation (required)
  • I have provided a minimal working example to reproduce the bug (required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants