Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] DeepMind Control Suite from pixels #235

Closed
1 task done
qgallouedec opened this issue Jan 17, 2023 · 2 comments · May be fixed by #150
Closed
1 task done

[Feature Request] DeepMind Control Suite from pixels #235

qgallouedec opened this issue Jan 17, 2023 · 2 comments · May be fixed by #150
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@qgallouedec
Copy link

Motivation

The wrapper to use DMCS with gym has an interesting feature that allows you to learn directly with the rendering (pixels), and not with the state. I don't see this feature integrated in envpool. Is it planned?

Solution

Could be an additional env kwargs:

envpool.make_dm("BallInCupCatch-v1", num_envs=1, from_pixels=True)

Or register those envs:

envpool.make_dm("BallInCupCatchImage-v1", num_envs=1)  # or BallInCupCatchFromPixels-v1, doesn't matter

Alternatives

I don't any workaround to use DeepMind control suite from pixel with envpool in the current state.

Additional context

From the paper

We also benchmarked a variant of D4PG that learns directly from pixel-only input, using 84 × 84 RGB frames from the 0th camera.

Checklist

  • I have checked that there is no similar issue in the repo (required)
@qgallouedec qgallouedec changed the title [Feature Request] DeepMind control suite from pixels [Feature Request] DeepMind Control Suite from pixels Jan 17, 2023
@Trinkle23897
Copy link
Collaborator

#150

@Trinkle23897 Trinkle23897 linked a pull request Jan 17, 2023 that will close this issue
@qgallouedec
Copy link
Author

I searched for "Deepmind Control Suite" and not for "dmc". Sorry for the duplicate. I close this issue, since it is in fact part of #136

@Trinkle23897 Trinkle23897 added the duplicate This issue or pull request already exists label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants