Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing multiple --protover flags to tlsclient #855

Closed
xvzcf opened this issue Nov 18, 2021 · 1 comment · Fixed by #856
Closed

Passing multiple --protover flags to tlsclient #855

xvzcf opened this issue Nov 18, 2021 · 1 comment · Fixed by #856

Comments

@xvzcf
Copy link

xvzcf commented Nov 18, 2021

The tlsclient usage string says that the --protover flag May be used multiple times.

How does one do so? I've tried passing in --protover 1.2 --protover 1.3, --protover 1.2 1.3 among other variations, but I just get an Invalid arguments. response.
@tanyav2 tanyav2 mentioned this issue Nov 18, 2021
Merged
@tanyav2
Copy link
Contributor

tanyav2 commented Nov 18, 2021

Created a PR that should fix the issue, it needs to be used as --protover 1.2 --protover 1.3 because docopt doesn't allow multiple arguments for an option as it goes against standard POSIX cli: docopt/docopt#484 (comment)

@ctz ctz closed this as completed in #856 Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

example client protover arg should allow multiple versions tanyav2/rustls
2 participants
@xvzcf @tanyav2