-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode Color Inaccurate #6518
Comments
maybe related to color space |
I am trying to find out what color space X11 is using in rocky 9.3. Do you happen to know where i could locate that information? My xorg config files do not specify a color space. |
My teradici connection appears to be using BGRA according to the session information. What does rustdesk use by default? |
@21pages what is the conclusion? |
No conclusion yet, it may related to 601 or 709, full range or limited range. On my computer there is not a lot of inaccuracy in the blue color, this issue is worth studying, I'll back to this issue soon. |
Thanks for your feedback, there is indeed a difference of one or two pixel values, most colors of anydesk are correct, here is the test result, https://github.com/21pages/test/releases/download/test/color.zip, I'll try to fix it. |
A similar scenario (sRGB on mac) is HDR on windows, #5368 |
Bug Description
We have noticed that the color accuracy of the video feed is inaccurate. When comparing any of the codec options with the newest nightly build with 4:4:4 color encoding enabled to Teradici PCoIP, we see color inaccuracy with the rustdesk remote connection. I am including screenshots of the rustdesk encode and the Pcoip encode.
How to Reproduce
Color inaccurate with every codec and with 4:4:4 color sample enabled or disabled.
Expected Behavior
Color to be accurate
Operating system(s) on local side and remote side
Rocky Linux 9.3 ->MacOS
RustDesk Version(s) on local side and remote side
Nightly 1.2.4 Nov 23rd 2023 -> Nightly 1.2.4 Nov 23rd 2023
Screenshots
Rustdesk nightly AV1 4:4:4
Teradici PCoIP
Additional Context
No response
The text was updated successfully, but these errors were encountered: