Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out missing display handle implementations #146

Open
9 of 12 tasks
madsmtm opened this issue Aug 31, 2023 · 6 comments
Open
9 of 12 tasks

Figure out missing display handle implementations #146

madsmtm opened this issue Aug 31, 2023 · 6 comments

Comments

@madsmtm
Copy link
Member

madsmtm commented Aug 31, 2023

RawDisplayHandle documents that (emphasis mine):

Not all windowing systems have a separate display handle (or they haven’t been implemented yet) and their variants contain empty structs.

So... We should probably track, and follow up on the ones that haven't been implemented yet!

Checklist:

  • UiKit - No display server (exposed to users, at least)
  • AppKit - No display server (exposed to users, at least)
  • Orbital - Unknown
  • Xlib - Implemented
  • Xcb - Implemented
  • Wayland - Implemented
  • Drm - Implemented
  • Gbm - Implemented
  • Windows - No display server (exposed to users, at least)
  • Web - Doesn't use this concept
  • Android - Unknown
  • Haiku - Unknown
@notgull
Copy link
Member

notgull commented Sep 1, 2023

For Win32, there isn't really a concept of a display. Some structures are thread local, but overall there is very little context for the windows. Leaving it empty is probably the right choice. I am not familiar with WinRT.

Web stuff is generally contextualized by the window/document, which is often cached. But given that it can be derived from anywhere it might not be worth it.

I don't know other platforms well enough to comment on them.

@kchibisov
Copy link
Member

Everything which is not implemented is not needed or doesn't exist as a concept. I remember discussing it with you on #matrix and I told that it's more about platforms having a concept of multiple display servers, so they need a way to distinguish between them, which is only an issue on platforms with the freedom to choose the display server.

@madsmtm
Copy link
Member Author

madsmtm commented Sep 1, 2023

I do remember too, I was just unsure if we were still missing something.

I guess I'll reword that section at some point then, and then close this issue.

@madsmtm
Copy link
Member Author

madsmtm commented Sep 3, 2023

The documentation, as far as I could find it, says that you're allowed to pass EGL_DEFAULT_DISPLAY (i.e. a null-ptr) on Wayland too? So why are we restricting that?

@madsmtm
Copy link
Member Author

madsmtm commented Sep 3, 2023

And it seems like HaikuOS just got the ability to pass a handle as well, although that doesn't really sound stable yet.

@kchibisov
Copy link
Member

The documentation, as far as I could find it, says that you're allowed to pass EGL_DEFAULT_DISPLAY (i.e. a null-ptr) on Wayland too? So why are we restricting that?

you could try, but it'll fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants