-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] supply static crt MT binary build for windows. #616
Comments
I am considering this, but would like to restrict the feature combinations for the static crt binaries. Currently we build 9 different combinations for Windows. What features do you need to build skia-safe / skia-bindings with? |
I think this static crt is what I needed. |
With feature combination I am relating to the cargo features of skia-safe and skia-binaries. We support features for rendering with OpenGL, for example |
Hi, we are trying to set crt-static for a project which ends up producing a MT linked NodeJS module. If we enable crt-static, rust-skia looks for a
It looks like it's maybe something to do with the environment/deps. It would be helpful when/if this merges, and some static variants are available. |
I think you can set FORCE_SKIA_BUILD=1 |
Thanks @tronical. I think it actually is attempting to build after failing to pull the static artifact, but failing with the "The system cannot find the file specified," and the error about not being able to find the '-static' prebuilt is just a red herring. I checked and gn.exe exists:
As well as clang-cl I can build with the same environment, with crt-static enabled and a fresh checkout of rust-skia @ 0.55. The full output is:
|
when I use rust-skia and rusty_v8 together, the rust-skia binary release is MD, while rusty_v8 binary is MT,link will failed. so I think It's more convenient to supply a MT build binary.
The text was updated successfully, but these errors were encountered: