Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for SkSVGDOM #545

Open
samizdatco opened this issue Jul 21, 2021 · 4 comments
Open

Add bindings for SkSVGDOM #545

samizdatco opened this issue Jul 21, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@samizdatco
Copy link
Contributor

samizdatco commented Jul 21, 2021

Would it be possible to add bindings for the SkSVGDOM class? Being able to parse SVG files and draw them to the canvas would be a terrific enhancement.

See also: SvgTool.cpp for a minimal use case.

@pragmatrix
Copy link
Member

Being able to parse SVG files and draw them to the canvas would be a terrific enhancement.

Agreed, and as I can see from the Network graph, @triniwiz already attempted to extend the bindings, may be you can collaborate?

@pragmatrix pragmatrix added the enhancement New feature or request label Aug 3, 2021
@triniwiz
Copy link
Contributor

triniwiz commented Aug 3, 2021

It's based of another fork that started the svg support all I added was image loading (my work is mostly around mobile)

@pragmatrix
Copy link
Member

@triniwiz Is it possible to draw SVG files with that branch? We don't have to implement the full SkSVGDOM API (Node, etc.) for a first MVP, rendering should cover most use cases I guess.

@triniwiz
Copy link
Contributor

triniwiz commented Aug 3, 2021

Yes it works fine for my usage passing a string or path from Android/iOS to render . One more thing I know some are a bit picky with it comes to adding dependencies since I added reqwest. It was added from my understanding that embedders need to handle those asset loading e.g images , fonts(did not tackle this one) ..etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants