Callout Work #150
Open
Callout Work #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sketches out the types for callout data.
This allows running builds + tests directy from Code.
iwillspeak
force-pushed
the
feature/progress-callbacks
branch
from
9581b38
to
6cb0aea
Compare
Expose some of the properties on the `CalloutArgs`. Allow registering objects which implement `Callout` on the match param. Still TODO: * Dropping of callout * Register global callout
Introduce getter for stack use.
This function overwrites the callout data, rather than adding. Update the API name to match that.
Now match params are passed as references the tests need updating to match.
Bump the major version, and MSRV. This is needed due to the API breaking change introduced in `search_with_param` and `match_with_param`. It also allws us to bump the MSRV to support our switch to Rust 2021.
iwillspeak
force-pushed
the
feature/progress-callbacks
branch
from
1905650
to
35adc35
Compare
Support retrieving callout names from callouts.
Expose subject and contents strings from the `CaptureArgs`.
iwillspeak
commented
Aug 29, 2022
There was a problem hiding this comment.
This changes the public API of the match_with_param and search_with_param functions to allow sharing a match param between more than one call. This seems like the better API, and
if we're bumping to 2021 we might as well. I don't imagine it will be too much of an issue as those
aren't the most widely used parts of the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81