Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Match Param Progress Callbacks #81

Open
iwillspeak opened this issue Mar 24, 2018 · 2 comments · May be fixed by #150
Open

Investigate Match Param Progress Callbacks #81

iwillspeak opened this issue Mar 24, 2018 · 2 comments · May be fixed by #150

Comments

@iwillspeak
Copy link
Collaborator

Currently there is provisional support in the onig_sys API for these. Do we need to add any structured wrapper?

Split off from #75 .

@iwillspeak
Copy link
Collaborator Author

The code in question is here in onig_sys.

Add support for setting both of these callbacks on MatchParam.

@iwillspeak
Copy link
Collaborator Author

This will require modelling of the OnigCalloutArgs and access to them. I'm not sure how much of this has been stableised yet. From some poking around:

  • Add a callout module which contains:
    • The CalloutArgs wrapper around the raw onig callout args pointer.
    • A Callout trait which can model something that can recive callouts. This trait should be implemented for Fn<CalloutArgs>.
  • Changes to the MatchParam to allow a Callout to be registered. This will probably require storing the closure in the MatchParam and passing some raw function through to 'unpack' the Callout from the MatchParam via user data.

@iwillspeak iwillspeak linked a pull request Oct 3, 2020 that will close this issue
@iwillspeak iwillspeak self-assigned this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant