Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected panics when onig returns an error when searching #178

Open
jszwedko opened this issue Aug 24, 2023 · 0 comments
Open

Unexpected panics when onig returns an error when searching #178

jszwedko opened this issue Aug 24, 2023 · 0 comments

Comments

@jszwedko
Copy link

Hi all!

We use this crate by way of the grok crate. It appears that search_with_encoding panics if Oniguruma returns an error:

https://github.com/rust-onig/rust-onig/blob/main/onig/src/lib.rs#L632-L650

It seems preferable to me to have the error returned so that it can be handled. Is there a design reason it panics instead? It seems like errors there are not uncommon as we have users of Vector reporting these panics (see: vectordotdev/vector#15199).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant