Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement product_axis #1351

Closed
unrenormalizable opened this issue Jan 24, 2024 · 2 comments · Fixed by #1387
Closed

Implement product_axis #1351

unrenormalizable opened this issue Jan 24, 2024 · 2 comments · Fixed by #1387

Comments

@unrenormalizable
Copy link

unrenormalizable commented Jan 24, 2024 •
edited by nilgoyette

product_axis is like sum_axis but for product. numpy has this implemented. it is the torch.prod equivalent with the dim argument. It will be good to have this implemented.

Some of the libraries I work with - mainly burn - is adding this functionality but i have to implement it for ndarray in the burn codebase.
@nilgoyette
Copy link
Collaborator

I think this is a good idea, since we have sum and sum_axis.

I was about to code it with fold_axis or map_axis, but it seems that we can use that function as a basis.

@rust-ndarray rust-ndarray deleted a comment from unrenormalizable Jan 25, 2024
This was referenced Feb 1, 2024
Open
Closed
@akern40 akern40 mentioned this issue May 18, 2024
Merged
@akern40
Copy link
Contributor

akern40 commented May 18, 2024

Hello! Would love to continue contributing, and looking for some more low-hanging fruit; just submitted a PR to close this, please let me know if there's any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement product_axis akern40/ndarray
3 participants
@nilgoyette @akern40 @unrenormalizable