Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of #[allow(static_mut_refs)] with SyncUnsafeCell #125035

Open
saethlin opened this issue May 12, 2024 · 6 comments
Open

Replace uses of #[allow(static_mut_refs)] with SyncUnsafeCell #125035

saethlin opened this issue May 12, 2024 · 6 comments
Assignees
@obeis
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@saethlin
Copy link
Member

saethlin commented May 12, 2024 •
edited by rustbot

#124895 is adding a number of FIXME comments on #[allow(static_mut_refs)] in the compiler. This issue tracks fixing them.

See #124895 (comment)
@saethlin saethlin added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 12, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 12, 2024
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 12, 2024
@saethlin saethlin mentioned this issue May 12, 2024
Draft
@workingjubilee
Copy link
Contributor

Hm, I wonder if it works like...

cc @obeis

@RalfJung
Copy link
Member

As before, I'm not sure SyncUnsafeCell is the right solution. In many cases it should probably just be raw pointers.

@RalfJung
Copy link
Member

@rustbot assign @obeis

@rustbot rustbot self-assigned this May 12, 2024
@obeis
Copy link
Contributor

obeis commented May 12, 2024

@rustbot claim

@rustbot rustbot assigned obeis and unassigned rustbot May 12, 2024
@RalfJung
Copy link
Member

RalfJung commented May 12, 2024 •
edited

🤔 I thought claim is just an alias for assign <me>... very strange. Oh well.

@workingjubilee
Copy link
Contributor

GH API design sure includes some... choices.

@jieyouxu jieyouxu added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obeis obeis

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@RalfJung @saethlin @jieyouxu @workingjubilee @rustbot @obeis