Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/crashes/124436.rs is creating a mir_dump directory in the repo root, not the build directory #125029

Closed
saethlin opened this issue May 11, 2024 · 1 comment · Fixed by #125032
Closed

tests/crashes/124436.rs is creating a mir_dump directory in the repo root, not the build directory #125029

saethlin opened this issue May 11, 2024 · 1 comment · Fixed by #125032
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.

Comments

@saethlin
Copy link
Member

#124775 added some tests, and one of them is creating a mir_dump directory in the repo root, where it really shouldn't. Surely we have ways of dumping MIR to other directories for the mir-opt tests, right?

@matthiaskrgr
@saethlin saethlin added the C-bug Category: This is a bug. label May 11, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 11, 2024
@saethlin saethlin added A-testsuite Area: The testsuite used to check the correctness of rustc and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 11, 2024
@compiler-errors compiler-errors mentioned this issue May 11, 2024
Merged
@compiler-errors
Copy link
Member

Yeah this has been annoying me recently. I put up #125032.

@bors bors closed this as completed in a71c3ff May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make crashes dump mir to build dir compiler-errors/rust
3 participants
@compiler-errors @saethlin @rustbot