Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixing query and update calls is not thread safe when using a single client instance #31

Open
msalvadores opened this issue Apr 13, 2013 · 1 comment
Assignees
Labels
support wontfix This will not be worked on

Comments

@msalvadores
Copy link

One could run into race condition issues when having one client used by multiple threads to run query and update calls. This is due to the use of instance variables in the make_post_request method:

request['Content-Type'] = 'application/sparql-' + (@op || :query).to_s

https://github.com/ruby-rdf/sparql-client/blob/master/lib/sparql/client.rb#L505

@ghost ghost assigned artob Apr 13, 2013
@artob
Copy link
Member

artob commented Apr 13, 2013

Thanks for reporting. I'm not sure that the client is otherwise thread-safe, though; it's encapsulating a single HTTP connection, after all. Will evaluate whether it makes any sense to define it as thread safe when we get around to the next release.

@gkellogg gkellogg added the wontfix This will not be worked on label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants