Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: 3-state booleans don't require a default #343

Open
joerixaop opened this issue Aug 29, 2023 · 3 comments
Open

Suggestion: 3-state booleans don't require a default #343

joerixaop opened this issue Aug 29, 2023 · 3 comments

Comments

@joerixaop
Copy link

I'm not quite sure why it's necessary for booleans to have a default value. Obviously when you are adding a boolean column to an existing table it may be required, because adding non-null columns requires a default in most cases. A newly created table however doesn't have a technical need for a default value for non-null tables, and it seems entirely plausible for a column not to have a good default value (whether it's an integer/string or as in this case a boolean).

@pirj
Copy link
Member

pirj commented Aug 29, 2023

Have you had a chance to check #275 #337 #43?

@joerixaop
Copy link
Author

joerixaop commented Aug 30, 2023

#43 is about where to add a default if you want to add one. I don't want to add one, but I do think a lint about booleans not being nullable is sensible, adding a requirement for a default value in that same lint makes it difficult to use when you do not want a default value .

#275 doesn't seem to have any discussion about why requiring a default would be part of the lint that requires a boolean to be not-null. The linked blog post points out what I also pointed out: a default is required when adding a column to an existing table with existing rows, that is guaranteed to be not the case when you are adding a boolean column with create_table.

I don't really understand what #337 has to do with default values (boolean or otherwise).

@pirj
Copy link
Member

pirj commented Sep 2, 2023

If you would decide to send a PR, what would it add/remove/change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants