Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad links in Appendix B Quick References #18

Open
StefRe opened this issue Nov 19, 2021 · 9 comments
Open

Bad links in Appendix B Quick References #18

StefRe opened this issue Nov 19, 2021 · 9 comments

Comments

@StefRe
Copy link

StefRe commented Nov 19, 2021

While the links are OK in the original cheat sheet https://github.com/rougier/scientific-visualization-book/blob/master/figures/cheatsheets/cheatsheets.pdf, they get corrupted in the individual sheet 1
https://github.com/rougier/scientific-visualization-book/blob/master/figures/cheatsheets/cheatsheets-1.pdf and hence in the book:
grafik

(this may or may not be linked to switch to Font Awesome for icons and brand logos).

@rougier
Copy link
Owner

rougier commented Nov 22, 2021

Oh thanks. Could you make a PR (else I can correct myself)?

@StefRe
Copy link
Author

StefRe commented Nov 22, 2021

I tried but I have only very basic knowledge of tex and didn't succeed. So I'm afraid I won't be of any help here.

@rougier
Copy link
Owner

rougier commented Nov 22, 2021

Oh wait, you're right. I directly included the PDF cheatsheets and this would require to change the PDF inside the book repo. I'll let this issue open until next edition (since matplotlib cheatsheets are continuously modified).

@StefRe
Copy link
Author

StefRe commented Nov 22, 2021

Hm, I'm not sure: as I wrote above, the big cheatsheet is fine, no need to change it for this reason. The issue comes from including the trimmed graphics when splitting it into several pages:

\includegraphics[trim=0cm 0cm 17.82cm 0cm, clip,height=210mm]{cheatsheets.pdf}

I read a bit about it and tried it with adjustbox as suggested on tex.stackexchange but with the same result (I'm completely new to tex).

@rougier
Copy link
Owner

rougier commented Nov 22, 2021

Could you try the PDF version included in the pdf repository in this repo to check if you got the same problem?

@StefRe
Copy link
Author

StefRe commented Nov 23, 2021

I did use the PDF version included in this repo, see links in the original post above.

I also checked out matplotlib/cheatsheets@2e1d87bd3d03 which included png graphic icons instead of fontawsome icons and tried it with this pdf: same result (so I stroke through my assumption above).

@rougier
Copy link
Owner

rougier commented Nov 23, 2021

For me, links seemed to be correct. Weird.

@StefRe StefRe changed the title Bad links in cheat sheet Bad links in Appendix B Quick References Nov 23, 2021
@StefRe
Copy link
Author

StefRe commented Nov 23, 2021

Sorry, maybe I didn't express myself unambiguously: the links in the complete cheat sheet work, but after splitting them into individual pages and hence in the book (page 236) they are corrupted (I change the title of this issue to make it clearer).

Do the links in the book indeed work for you?

@rougier
Copy link
Owner

rougier commented Nov 23, 2021

Yes, I was talking about book links. But I think I've read somewhere (stack overflow ?) that when you include PDF inside latex, links are no preserved and I wonder how I end up with working links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants