Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person providers remove duplicate names and sort name vectors #87

Open
kylevoyto opened this issue Jul 31, 2018 · 4 comments
Open

Person providers remove duplicate names and sort name vectors #87

kylevoyto opened this issue Jul 31, 2018 · 4 comments

Comments

@kylevoyto
Copy link
Contributor

  • I've seen duplicate names in the person-providers that I've worked with, e.g. fr_FR had "Margot" twice in the first_name_female vector. I can imagine there are duplicate names in other locales. A thorough sweep should be performed on all locales.
  • All name vectors in all locales should be sorted alphabetically (for cleanliness). Many of the vectors already are. But a sweep should be performed.
@sckott
Copy link
Collaborator

sckott commented Jul 31, 2018

👍 agree, thanks

@MartinMSPedersen
Copy link
Contributor

I think this can be closed because my PR #96
should solve this.

@sckott
Copy link
Collaborator

sckott commented Oct 5, 2018

thanks will have a look

@sckott
Copy link
Collaborator

sckott commented Oct 5, 2018

thanks @MartinMSPedersen - but we should probably check the other person provider files before closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants