Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify other maintainers of the changes in next version #140

Open
3 tasks done
RMHogervorst opened this issue Oct 21, 2023 · 0 comments
Open
3 tasks done

Notify other maintainers of the changes in next version #140

RMHogervorst opened this issue Oct 21, 2023 · 0 comments
Assignees
Labels
internals Internal changes
Milestone

Comments

@RMHogervorst
Copy link
Contributor

RMHogervorst commented Oct 21, 2023

This is a task to let the maintainers of downstream packages know that I'm going to change a few things.

DataFakeR

Uses charlatan::ch_name
The functionality of the ch_name remains the same, but it is wise to set the locale to en_US
to make it clear what locale you want to use.

ch_name(n=1, locale = "en_US")

fakir

Uses

importFrom(charlatan,ch_color_name)
importFrom(charlatan,ch_company)
importFrom(charlatan,ch_credit_card_provider)
importFrom(charlatan,ch_job)
charlatan::ch_element_symbol(1)
@importFrom charlatan ch_name ch_credit_card_provider ch_job
@importFrom charlatan ch_name ch_credit_card_provider ch_job

All functionality remains the same, however I will throw a warning about the locale.
If you want to prevent the warning in future release when it hits CRAN, set the "en_US" locale like so:

ch_color_name(n=1, locale="en_US")

salty

uses charlatan::ch_name(10)
The functionality of the ch_name remains the same, but it is wise to set the locale to en_US
to make it clear what locale you want to use.

ch_name(n=1, locale = "en_US")
@RMHogervorst RMHogervorst added the internals Internal changes label Oct 21, 2023
@RMHogervorst RMHogervorst added this to the v0.6 milestone Oct 21, 2023
@RMHogervorst RMHogervorst self-assigned this Oct 21, 2023
@RMHogervorst RMHogervorst pinned this issue Oct 21, 2023
RMHogervorst added a commit that referenced this issue Oct 21, 2023
RMHogervorst added a commit that referenced this issue Oct 21, 2023
Upgraded all providers

Add new vignette creating realistic data

Fix #52 Fix #61

Fix bug personprovider

Fix roxygenbugs

Add revdep check

See #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal changes
Projects
None yet
Development

No branches or pull requests

1 participant