Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

馃悰 Disabling a nursery rule, disable all nursery rules when global all is set. #4602

Open
1 task done
Conaclos opened this issue Jun 22, 2023 · 0 comments
Open
1 task done
Labels
S-To triage Status: user report of a possible bug that needs to be triaged

Comments

@Conaclos
Copy link
Contributor

Conaclos commented Jun 22, 2023

Environment information

CLI:
  Version:                      12.1.3-nightly.50eb45f
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.3.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/8.19.2"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Rome servers...

What happened?

Given the following configuration:

{
  "linter": { "rules": {
      "all": true,
      "nursery": { "noConfusingArrow": "off" }
    }
} }

or even simpler:

{
  "linter": { "rules": {
      "all": true,
      "nursery": { }
    }
} }

The following code doesn't trigger useNamingConvention

export function TEST() {}

While the following config did:

{
  "linter": { "rules": {
      "all": true
    }
} }

I think it is an unintended effect from #4511.

Expected result

All nursery rules should be enabled (except the ones turned off).

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@Conaclos Conaclos added the S-To triage Status: user report of a possible bug that needs to be triaged label Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-To triage Status: user report of a possible bug that needs to be triaged
Projects
None yet
Development

No branches or pull requests

1 participant