Fixes #16 #17
Open
Fixes #16 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lopierra I missed this. This looks great! The only issue I see is this: |
…and change column widths to 6 and 6 (was previously 4 for DT and 8 for map). There is still overlap when browser window is very narrow, but at least it now works on my 13" laptop.
|
Thanks for testing! I didn't notice the overlap because my monitor at work is pretty wide. I resized the columns to 6 and 6 (previously 4 for table and 8 for map), so now it works on my small laptop as well. There is overlap if you make the browser window very narrow, but I'm not sure that can be avoided. I think I see my commit here already, but let me know if there is something else I need to do. Thanks! Fixes #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently learned how to use DataTables, so I thought I would revisit this. Fixes #16 .