Skip to content
This repository has been archived by the owner on Mar 23, 2022. It is now read-only.

Update samples #184

Open
stjepan opened this issue May 9, 2019 · 0 comments
Open

Update samples #184

stjepan opened this issue May 9, 2019 · 0 comments

Comments

@stjepan
Copy link

stjepan commented May 9, 2019

I noticed some of your samples aren't updated/correctly setup. You should update them to at least cover minimum supported target versions, which are .net core 2.1 and .net framework 4.6.1

This is how it looks today and some suggestions:

samples/UsageSample.AspNetCore

  • targets .net core 2.1

samples/UsageSample.BearerTokenTester

  • targets .net 4.5, but should be updated for .net 4.6.1

samples/ServerTester

  • targets .net 4.6.1, but is not correctly configured:
  • App.config
    change sku to .NETFramework,Version=v4.6.1

samples/UsageSample

  • targets .net 4.6.1, but is not correctly configured:
  • Web.config
    change both targetFramework to 4.6.1

samples/UsageSampleMvc.AspNetCore

  • targets .net core 2.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant