Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Active Record 4.2 WIP #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dschweisguth
Copy link
Contributor

@dschweisguth dschweisguth commented Jun 30, 2017

This PR intends to fix #12. It starts with a reapplication of the changes in https://github.com/fjl82/activerecord-mysql2spatial-adapter to current master.

To do:

  • fix tests
  • upgrade mysql2 dependency to 0.4.*, if that can be done without much extra work
  • bump activerecord-mysql2spatial-adapter version, probably to 0.6.0

@januszm
Copy link
Contributor

januszm commented Jun 30, 2017

@dschweisguth I'd like to propose changes in baby steps, let's first add compatibility with newer rgeo , merge, and then let's focus on ActiveRecord 4.2

Also, things like code cleanup and .gitignore / Gemfile improvements we can do in a separate PR. It'll be easier to handle this and we'll deliver results in smaller increments, faster.

@dschweisguth
Copy link
Contributor Author

I based this on the branch for my previous PR. Only the last commit here will remain after that other branch is merged and this one is rebased.

@januszm januszm changed the title Upgrade Active Record dependency to 4.2 (not complete, in progress) Support Active Record 4.2 WIP Jul 14, 2017
@dschweisguth dschweisguth force-pushed the 4.2-compatibility branch 2 times, most recently from f2fc87a to f14b07f Compare July 21, 2017 18:01
This commit reapplies fjl82 and agoln's commits from
fjl82/activerecord-mysql2spatial-adapter to current master.
Not all tests pass yet.
@guizmaii
Copy link

guizmaii commented Aug 12, 2018

Hi,

Any news ?

@januszm
Copy link
Contributor

januszm commented Aug 15, 2018

I think it's time to find a new maintainer for this project, I have not used this in my work for a long time.

I'll look at your new PR soon

@dschweisguth
Copy link
Contributor Author

Other things are taking my time right now. I'll eventually get back to the project that uses this gem, but not very soon. Please do tell me if I should rebase anything of mine or test new releases of this gem against my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ActiveRecord 4.2
3 participants