Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible Error in constructors #171

Open
parit opened this issue Apr 18, 2023 · 1 comment · May be fixed by #175
Open

Possible Error in constructors #171

parit opened this issue Apr 18, 2023 · 1 comment · May be fixed by #175

Comments

@parit
Copy link

parit commented Apr 18, 2023

Hello,

In Drawer.js there is line 47

this.svgDrawer.draw(data, svg, themeName, infoOnly, highlight_atoms);

where as In SvgDrawer.js line 31 expects a weights param:

draw(data, target, themeName = 'light', weights = null, infoOnly = false, highlight_atoms = [], weightsNormalized = false)

Can someone please check this on master branch? Seems like a bug to me. Thanks.
@panda-byte
Copy link

I am using smiles-drawer and this error affected me. As far as I can tell, it was introduced in f3693b3, where the weights parameter was added, but in Drawer.js the corresponding call wasn't updated.

panda-byte pushed a commit to panda-byte/smilesDrawer that referenced this issue Jun 15, 2023
@christoph-elfmann
Pass default value weights = null to SvgDrawer.draw() from `Drawe…
2c5d7ab 
…r.draw()`

Resolves reymond-group#171. Although the `weights` parameter was added to
`SvgDrawer.draw()` in f3693b3, the method call in `Drawer.draw()` wasn't
updated correspondingly. `Drawer.draw()` could be amended to also take a
`weights` argument, which it would pass to `SvgDrawer.draw()`, but this might
break existing code even more and would require an update of the
documentation of the README.
@panda-byte panda-byte linked a pull request Jun 15, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass default value weights = null to SvgDrawer.draw() panda-byte/smilesDrawer
2 participants
@parit @panda-byte