Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] clade probabilities with sampled ancestors #467

Open
hoehna opened this issue May 7, 2024 · 0 comments
Open

[BUG] clade probabilities with sampled ancestors #467

hoehna opened this issue May 7, 2024 · 0 comments
Assignees

Comments

@hoehna
Copy link
Member

hoehna commented May 7, 2024

Describe the bug
The MAP tree function doesn't compute the posterior probabilities of clades correctly when having sampled ancestors. Here we have a fake traces of 5 trees, all the same topology. The only difference is that one tip is set as sampled ancestor 3 out of 5 times. All PP of clades should be 1.0, but aren't.

Two more issues:

  1. The first tree is omitted even though the burnin is 0.
  2. The node age of the sampled ancestor is set to the non-sampled ancestor state. Why?

To Reproduce

trace = readTreeTrace("TryTreeWithSA.trees",burnin=0,treetype="clock")
mapTree(trace,file="map.tre")

TryTreeWithSA.trees.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants