Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action on tool delete #203

Open
hansioan opened this issue Apr 4, 2020 · 1 comment
Open

Action on tool delete #203

hansioan opened this issue Apr 4, 2020 · 1 comment

Comments

@hansioan
Copy link
Collaborator

hansioan commented Apr 4, 2020

@bgruening @hmenager @joncison @matuskalas @piotrgithub1

Hi all,

This issue is regarding tool deletion from the ecosystem, especially pull requests coming from outside (e.g. from bio.tools or from forks).

It could be the case that in our content file structure we have something like:
data/tool_id/tool_id.biotools.json where this is the only file. If we delete this file then the whole folder goes as well, if this is intended behaviour it's fine but we just have to agree on what happens on delete.

I was thinking of, istead of deleting the file immediately, especially when changes are coming from bio.tools perhaps we can mark tools as deleted by renaming the bio.tools files to something like .deleted.tool_id.biotools.json. In this way the folder doesn't go away.

I think we can code and handle both cases, it's just that we have to agree on what we want the functionality to be. What are your opinions on this? Please tag other people.

@hansioan
Copy link
Collaborator Author

hansioan commented Apr 8, 2020

I agree with @piotrgithub1 suggestion that we rename the entry rather than delete it, but keep the .deleted part at the end, i.e. tool_id.biotools.json.deleted
In this way the file won't have a .json extension, but a .deleted extension which will separate it from regular .json files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant