Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tool detection to renovatebot/detect-tools #29000

Open
rarkins opened this issue May 11, 2024 · 0 comments
Open

Move tool detection to renovatebot/detect-tools #29000

rarkins opened this issue May 11, 2024 · 0 comments
Assignees
Labels
priority-2-high Bugs impacting wide number of users or very important features type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 11, 2024

Describe the proposed change(s).

We should move tool detection to a separate repo/module so that it can be shared outside Renovate, particularly with some Containerbase tooling we are building.

Start with Poetry and Pipenv.

Example from: https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/pipenv/artifacts.ts

Instead of a getPythonConstraint() function where we pass content to the function, we should instead call our new external library and pass it a fully qualified path/directory.

@rarkins rarkins added priority-2-high Bugs impacting wide number of users or very important features type:refactor Refactoring or improving of existing code labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2-high Bugs impacting wide number of users or very important features type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

2 participants