Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address empty in version when registering an account #1706

Open
8 tasks
ryanchristo opened this issue Dec 20, 2022 · 1 comment
Open
8 tasks

Address empty in version when registering an account #1706

ryanchristo opened this issue Dec 20, 2022 · 1 comment
Labels
Scope: x/intertx Issues that update the x/intertx module Type: Bug Something isn't working

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Dec 20, 2022

Summary of Bug

While testing the intertx module, I was running into a key not found error after registering an ica account with tx intertx register and then querying for the account with q intertx ica.

The transaction is successful but I noticed in the transaction address was not being populated within version and manually passing the --version flag with tx intertx register that includes the address resolved the issue.

We should further investigate why address is not being included in version and ideally this would be automatically populated and passing the --version flag with tx intertx register would not be required.

Version

release/v5.0.x

Steps to Reproduce

See https://hackmd.io/L4Ru-CeuQZ6VMMrBXYDHLA

The address in version is not populated:

regen tx intertx register --from $WALLET_3 --connection-id connection-0 --home ./data/regen-ica
{"fee_version":"ics29-1","app_version":"{\"version\":\"ics27-1\",\"controller_connection_id\":\"connection-0\",\"host_connection_id\":\"connection-0\",\"address\":\"\",\"encoding\":\"proto3\",\"tx_type\":\"sdk_multi_msg\"}"}

The address in version is manually set and the account can be queried:

regen tx intertx register --from $WALLET_3 --connection-id connection-0  --version '{"version":"ics27-1","tx_type":"sdk_multi_msg","encoding":"proto3","host_connection_id":"connection-0","controller_connection_id":"connection-0","address":"regen14zs2x38lmkw4eqvl3lpml5l8crzaxn6mpvh79z"}' --home ./data/regen-ica
regen q intertx ica $WALLET_3 connection-0

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added the Type: Bug Something isn't working label Dec 20, 2022
@ryanchristo ryanchristo changed the title Address not automatically populated in version when registering an account Address empty in version when registering an account Dec 21, 2022
@ryanchristo
Copy link
Member Author

This would be a non-api or state breaking change to resolve and therefore we can resolve following the v5.0 release.

@ryanchristo ryanchristo added the Scope: x/intertx Issues that update the x/intertx module label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/intertx Issues that update the x/intertx module Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant