Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use gotest.tools/v3/assert instead of testify/require #1487

Open
4 tasks
technicallyty opened this issue Sep 12, 2022 · 1 comment
Open
4 tasks

tests: use gotest.tools/v3/assert instead of testify/require #1487

technicallyty opened this issue Sep 12, 2022 · 1 comment
Labels
Status: Backlog Type: Tests

Comments

@technicallyty
Copy link
Contributor

Summary

the sdk team will be replacing usage of stretchr/testify with gotest.tools/v3/assert. we should do the same to stay aligned with the sdk.

Problem Definition

ref:
cosmos/cosmos-sdk#12291 (comment)

Proposal

use gotest.tools/v3/assert where for future tests and possibly update older tests.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@technicallyty technicallyty mentioned this issue Sep 12, 2022
Merged
19 tasks
@ryanchristo
Copy link
Member

gotest.tools provides a command to automate the migration:

https://pkg.go.dev/gotest.tools@v2.2.0+incompatible/assert/cmd/gty-migrate-from-testify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Backlog Type: Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanchristo @technicallyty