Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Fix request timeout handling #8

Open
slorber opened this issue Jan 24, 2014 · 7 comments
Open

Fix request timeout handling #8

slorber opened this issue Jan 24, 2014 · 7 comments

Comments

@slorber
Copy link
Contributor

slorber commented Jan 24, 2014

When using a proxy, the proxy always respond within 10 sec, potentially with an error.
This is because there's a timeout set inside the proxy fetcher.

When not using a proxy, the jumping promise may stay unresolved. It there's no answer in 10 seconds I think the promise should be automatically rejected

@bblfish
Copy link
Member

bblfish commented Jan 24, 2014

sounds correct.

@slorber
Copy link
Contributor Author

slorber commented Jan 24, 2014

It is not really a timeout. Actually it works fine when it's a timeout (according to the rdflib code I see)
The "fail" hook is never called by rdflib on http error code when there is an error.

See this issue I opened
linkeddata/rdflib.js#27

@bblfish
Copy link
Member

bblfish commented Jan 24, 2014

It's worth trying to patch that, and send the patch in with your bug report ( if you can ). Because there are not a lot of resources on that there.

slorber added a commit that referenced this issue Jan 24, 2014
@slorber
Copy link
Contributor Author

slorber commented Jan 24, 2014

the rdflib code is a bit hard to correct.

I've added a Q timeout to the promise. It works nicely but I don't know why it seems the React rendering of PersonContactOnProfileJumpWrapper does not trigger the underlying PersonContactOnProfile component (shouldComponentUpdate is not even called :s)

@slorber
Copy link
Contributor Author

slorber commented Jan 28, 2014

Finally this seems more related to this issue:
linkeddata/rdflib.js#30

@matt-wallis
Copy link

matt-wallis commented May 11, 2016

I see that these issues related to timeouts are still open. Am I right to assume that they are unresolved? I think I may have hit the problem - my application just hangs after attempting to fetch a URI that involves 303 redirection, via my own proxy (although I am manually changing the URI, rather than using the Fetcher's proxy handling capabilities). My proxy is almost certainly flakey (being very new), but having the application hang is a real problem.
I am using the rdflib.js from the dist directory https://github.com/linkeddata/rdflib.js/blob/master/dist/rdflib.js, but I see that the copyright is up to 2014, so I am guessing it's quite old.

@bblfish
Copy link
Member

bblfish commented May 11, 2016

Hi, I have moved to work on the react based viewers written in ScalaJS. You may want to try that https://github.com/read-write-web/rww-scala-js . I am about to rewrite the server though, so it will be a bit of time before I get back to the client.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants