New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Build fails when using ReactiveWindow
with System.Text.Json
source generation
#3255
Comments
I seen this when your context isn't a partial class and decorated correctly. Check also the output window to see if the build failed. There's also a strong argument not to have view models be directly serialisable. |
I believe it is correctly written and decorated. The whole change is in this commit: database64128/youtube-dl-wpf@51947e6.
In this case it's not exactly a view model. The |
Yeah, Can be best if you do that. I'd be concerned with a fody and source generator interop as well. |
Turns out it was unrelated to Fody. For some reason it can be fixed by referencing the STJ package: database64128/youtube-dl-wpf@f201304, even though my project was already targeting .NET 6. |
Turns out the issue was caused by
|
[Reactive]
decorated properties can't be used with System.Text.Json
source generationReactiveWindow
with System.Text.Json
source generation
Describe the bug 馃悶
When a class with[Reactive]
decorated properties is used withSystem.Text.Json
source generation, build fails with the following errors:Update: See #3255 (comment) instead.
Step to reproduce
MainWindowViewModel
.Window
with RxUI'sReactiveWindow
.Reproduction repository
https://github.com/database64128/WPFRxUISTJSourceGenerationMinimalReproduction
Expected behavior
Build succeeds.
ReactiveUI Version
18.0.10
The text was updated successfully, but these errors were encountered: