Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using new R-Group Decomposition code #56

Open
greglandrum opened this issue Mar 15, 2019 · 4 comments
Open

Switch to using new R-Group Decomposition code #56

greglandrum opened this issue Mar 15, 2019 · 4 comments
Assignees

Comments

@greglandrum
Copy link
Member

greglandrum commented Mar 15, 2019

This probably means deprecating the current node since the options are now different.

The constructor for the data structure with the parameters for the C++ RGD code, which includes the default values, is here:
https://github.com/rdkit/rdkit/blob/master/Code/GraphMol/RGroupDecomposition/RGroupDecomp.h#L66

From a quick skim of the generated code, it looks like all of this is exposed to Java in a sensible way.

@manuelschwarze
Copy link
Contributor

@greglandrum, a few questions:

  1. What would be the parameters that we want to support beside the input Mol column?
  2. Is there a way to know the maximum number of R groups that will be in the output? (In the past we derived that number from the number of heavy atoms in the SMARTS core that was submitted as parameter)
  3. Some examples would be good. Brian said there are many available...

@manuelschwarze
Copy link
Contributor

@bp-kelley, feel free to answer as well

@greglandrum
Copy link
Member Author

@manuelschwarze, answers (I hope):

  1. I updated the description to include a pointer to the parameters. I will try to find some time to list those explicitly, but in case that doesn't happen, the line of C++ that I point to includes all the required info.
  2. Why do you need the max number of R groups and how important is it that the answer be correct? Most of the time you really don't know the number (or names) of output columns until you run the calculation.
  3. Sure, examples/tests are relatively easy to come up with by running some Python

@manuelschwarze
Copy link
Contributor

@greglandrum

  1. Thanks. Much clearer now.
  2. Before filling columns in KNIME I need to create them, but at that time the RGroupDecomp did not run yet. It is complicated to dynamically add columns to a table while you are already filling in data. I would like to avoid that, if possible. What I could do is to create always N columns (N very high) and then after filling the table removing the unused ones (or empty ones) again in a post processing step - that is quite easy. Question in that case would be what N should be? Is there a natural limit how many R groups can be created?
  3. Brian mentioned there are examples already available. Any useful link you can provide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants